Implementation of WUDAPT (31-41) landuse classes along with standard urban classes (31-33) #1419

davegill · 2021-02-26T20:16:29Z

TYPE: new feature

KEYWORDS: urban, local climate zone,

SOURCE: Developer: Andrea Zonato (University of Trento, Italy, [email protected])

DESCRIPTION OF CHANGES:
This update includes the extension of urban classes from 3 (31-33) to 11 WUDAPT Local Climate zones (31-41). See Stewart and Oke, 2012 for further details

Briefly, a new urban parameter table (URBPARAM_LCZ.TBL) has been added for using the new LCZ urban category. The new LCZ definition has LU_INDEX=LCZ+30. If a user still wants to keep using the traditional 33 classes (31st-33rd for urban), please specify the namelist option "use_wudapt_lcz = 0". If a user wants to use the new LCZ, please specify the namelist option "use_wudapt_lcz = 1". If the number of urban category in the input files is inconsistent with the namelist option, error messages will occur. Only the LCZ modeling capability is provided here, not the dataset which is the responsibility of users. The method to create the LCZ data is described in the World Urban Database website: http://www.wudapt.org/

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M Registry/Registry.NMM
M main/depend.common
M dyn_em/module_initialize_real.F
M main/depend.common
M phys/Makefile
A phys/module_bep_bem_helper.F
M phys/module_physics_init.F
M phys/module_sf_bep.F
M phys/module_sf_bep_bem.F
M phys/module_sf_clm.F
M phys/module_sf_noahdrv.F
M phys/module_sf_noahlsm.F
M phys/module_sf_noahmpdrv.F
M phys/module_sf_noahmplsm.F
M phys/module_sf_urban.F
M phys/module_surface_driver.F
M run/LANDUSE.TBL
M run/MPTABLE.TBL
M run/URBPARM.TBL
A run/URBPARM_LCZ.TBL
M run/VEGPARM.TBL
A share/module_check_a_mundo.F

TESTS CONDUCTED:

Jenkins testing OK

RELEASE NOTE:
Stewart, I.D. and Oke, T.R. (2012) Local Climate Zones for Urban Temperature Studies. Bulletin of the American Meteorological Society, 93, 1879-1900.
http://dx.doi.org/10.1175/BAMS-D-11-00019.1

…asses

origin = andreazonato On branch LCZ_WUDAPT_WRF Your branch is up to date with 'origin/LCZ_WUDAPT_WRF'. Changes to be committed: modified: main/depend.common new file: phys/module_bep_bem_helper.F modified: phys/module_sf_bep.F modified: phys/module_sf_bep_bem.F modified: share/module_check_a_mundo.F

modified: phys/Makefile modified: phys/module_sf_bep.F modified: phys/module_sf_bep_bem.F

dyn_em/module_initialize_real.F

andreazonato · 2021-02-26T20:44:42Z

Yes, it is, since if not all classes greater than 30 with frc urb less than 0.5 would be turned into class 13 Il ven 26 feb 2021, 21:21 Dave Gill <[email protected]> ha scritto:

…

***@***.**** commented on this pull request. ------------------------------ In dyn_em/module_initialize_real.F <#1419 (comment)>: > @@ -2994,7 +2994,7 @@ SUBROUTINE init_domain_rk ( grid & DO i = its , MIN(ide-1,ite) IF ( MMINLU == 'NLCD40' .OR. MMINLU == 'MODIFIED_IGBP_MODIS_NOAH') THEN IF ( grid%FRC_URB2D(i,j) .GE. 0.5 .AND. & - (grid%ivgtyp(i,j).NE.13 .AND. grid%ivgtyp(i,j).NE.24 .AND. grid%ivgtyp(i,j).NE.25 .AND. grid%ivgtyp(i,j).NE.26)) grid%ivgtyp(i,j)=13 + (grid%ivgtyp(i,j).NE.13 .AND. grid%ivgtyp(i,j).NE.24 .AND. grid%ivgtyp(i,j).NE.25 .AND. grid%ivgtyp(i,j).NE.26 .AND. grid%ivgtyp(i,j).LT.30)) grid%ivgtyp(i,j)=13 @andreazonato <https://github.com/andreazonato> @cenlinhe <https://github.com/cenlinhe> Is this required for the LCZ mods? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1419 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALWNNTV7H4AKUYXTHX2YKM3TA77EHANCNFSM4YJBO3GA> .

davegill · 2021-02-26T20:56:04Z

@andreazonato @cenlinhe @weiwangncar @dudhia
This is a proposed replacement for #1411
This PR does not have the problem of incorrect urban classes based on the use_wudapt_lcz settings, and does not have the resultant slow down for the first time step.

davegill · 2021-02-26T21:01:11Z

jenkins:

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 01a591bbc0b7068716a693285739d2fe6cdd68a5, requested by: davegill for PR: https://github.com/wrf-model/WRF/pull/1419. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           18
    Number of Builds       : 48           46
    Number of Simulations  : 163           161        0
    Number of Comparisons  : 103           102        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

davegill · 2021-02-26T21:02:33Z

@andreazonato @cenlinhe @dudhia @weiwangncar
Who would be able to test this PR to see if it actually does the urban classes correctly?

cenlinhe · 2021-02-26T21:10:18Z

@davegill Thanks! I just took a look at your modification in this PR and it looks good to me. I will try to download this PR code and do a quick test to see if the results look reasonable.

davegill · 2021-02-26T21:19:38Z

@cenlinhe

I will try to download this PR code and do a quick test to see if the results look reasonable.

Thanks!

andreazonato · 2021-02-26T21:23:20Z

I read the code, and it seems a reasonable and fast way to do it. Sorry but I did I with the competences I have,and it was much more complicated and slow Il ven 26 feb 2021, 22:19 Dave Gill <[email protected]> ha scritto:

…

@cenlinhe <https://github.com/cenlinhe> I will try to download this PR code and do a quick test to see if the results look reasonable. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1419 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALWNNTW537HLK6K3M3EP6ODTBAF7RANCNFSM4YJBO3GA> .

davegill · 2021-02-26T21:33:41Z

@andreazonato
Absolutely no one gets a PR accepted without modifications. No one.

One of the benefits of an open development repository is that everyone can make suggestions to the source code.

That is also the biggest problem with open development. :)

We very much appreciate your scientific modifications to the code, and hope that you continue to be an active WRF model contributor.

cenlinhe · 2021-02-26T23:46:30Z

@davegill @andreazonato I just ran a few tests by using BEP and BEP_BEM scheme with Dave's new updates and it seems that the results are looking reasonable. Here are they: /glade/scratch/cenlinhe/WRF_noahmp_test/WRF_LCZ_test_1419/run/urban2/ and /glade/scratch/cenlinhe/WRF_noahmp_test/WRF_LCZ_test_1419/run/urban3/
I think the LCZ code is ready.

dudhia

large number of changes, but tested by LSM group

…urban classes (31-33) (wrf-model#1419) TYPE: new feature KEYWORDS: urban, local climate zone, SOURCE: Developer: Andrea Zonato (University of Trento, Italy, [email protected]) DESCRIPTION OF CHANGES: This update includes the extension of urban classes from 3 (31-33) to 11 WUDAPT Local Climate zones (31-41). See Stewart and Oke, 2012 for further details Briefly, a new urban parameter table (URBPARAM_LCZ.TBL) has been added for using the new LCZ urban category. The new LCZ definition has LU_INDEX=LCZ+30. If a user still wants to keep using the traditional 33 classes (31st-33rd for urban), please specify the namelist option "use_wudapt_lcz = 0". If a user wants to use the new LCZ, please specify the namelist option "use_wudapt_lcz = 1". If the number of urban category in the input files is inconsistent with the namelist option, error messages will occur. Only the LCZ modeling capability is provided here, not the dataset which is the responsibility of users. The method to create the LCZ data is described in the World Urban Database website: http://www.wudapt.org/ LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M Registry/Registry.NMM M main/depend.common M dyn_em/module_initialize_real.F M main/depend.common M phys/Makefile A phys/module_bep_bem_helper.F M phys/module_physics_init.F M phys/module_sf_bep.F M phys/module_sf_bep_bem.F M phys/module_sf_clm.F M phys/module_sf_noahdrv.F M phys/module_sf_noahlsm.F M phys/module_sf_noahmpdrv.F M phys/module_sf_noahmplsm.F M phys/module_sf_urban.F M phys/module_surface_driver.F M run/LANDUSE.TBL M run/MPTABLE.TBL M run/URBPARM.TBL A run/URBPARM_LCZ.TBL M run/VEGPARM.TBL A share/module_check_a_mundo.F TESTS CONDUCTED: 1. Jenkins testing OK RELEASE NOTE: Stewart, I.D. and Oke, T.R. (2012) Local Climate Zones for Urban Temperature Studies. Bulletin of the American Meteorological Society, 93, 1879-1900. http://dx.doi.org/10.1175/BAMS-D-11-00019.1

Andrea Zonato and others added 7 commits February 22, 2021 04:27

Implementation of WUDAPT landuse classes along with standard urban cl…

dcf9156

…asses

modification of module_initialize_real.F

f471039

WUDAPT line up 10:58 AM

e34e373

Merge branch 'develop' into LCZ_WUDAPT_WRF

0389a38

space 16:12 WUDAPT

f16d672

nurbmax (allocation) separate from nurbm (computational size)

01a591b

modified: phys/Makefile modified: phys/module_sf_bep.F modified: phys/module_sf_bep_bem.F

davegill requested review from a team as code owners February 26, 2021 20:16

davegill commented Feb 26, 2021

View reviewed changes

dyn_em/module_initialize_real.F Show resolved Hide resolved

davegill added PHYSICS New Feature Develop Branch labels Feb 26, 2021

davegill mentioned this pull request Mar 1, 2021

Implementation of WUDAPT (31-41) landuse classes along with standard urban classes (31-33) #1411

Closed

dudhia approved these changes Mar 2, 2021

View reviewed changes

davegill merged commit c2f9b99 into wrf-model:develop Mar 3, 2021

epn09 mentioned this pull request Jan 11, 2022

Segfault with sf_surface_mosaic in WRF4.3.1. #1633

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of WUDAPT (31-41) landuse classes along with standard urban classes (31-33) #1419

Implementation of WUDAPT (31-41) landuse classes along with standard urban classes (31-33) #1419

davegill commented Feb 26, 2021 •

edited by weiwangncar

Loading

andreazonato commented Feb 26, 2021 via email

davegill commented Feb 26, 2021

davegill commented Feb 26, 2021

davegill commented Feb 26, 2021

cenlinhe commented Feb 26, 2021

davegill commented Feb 26, 2021

andreazonato commented Feb 26, 2021 via email

davegill commented Feb 26, 2021

cenlinhe commented Feb 26, 2021

dudhia left a comment

Implementation of WUDAPT (31-41) landuse classes along with standard urban classes (31-33) #1419

Implementation of WUDAPT (31-41) landuse classes along with standard urban classes (31-33) #1419

Conversation

davegill commented Feb 26, 2021 • edited by weiwangncar Loading

andreazonato commented Feb 26, 2021 via email

davegill commented Feb 26, 2021

davegill commented Feb 26, 2021

davegill commented Feb 26, 2021

cenlinhe commented Feb 26, 2021

davegill commented Feb 26, 2021

andreazonato commented Feb 26, 2021 via email

davegill commented Feb 26, 2021

cenlinhe commented Feb 26, 2021

dudhia left a comment

Choose a reason for hiding this comment

davegill commented Feb 26, 2021 •

edited by weiwangncar

Loading